This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 1/3] Fix http://sourceware.org/bugzilla/show_bug.cgi?id=14550

From: Tom Tromey <tromey at redhat dot com>
To: Sanjoy Das <sanjoy at playingwithpointers dot com>
Cc: gdb-patches at sourceware dot org
Date: Tue, 18 Sep 2012 13:37:06 -0600
Subject: Re: [PATCH 1/3] Fix http://sourceware.org/bugzilla/show_bug.cgi?id=14550
References: <1347942847-31510-1-git-send-email-sanjoy@playingwithpointers.com> <1347942847-31510-2-git-send-email-sanjoy@playingwithpointers.com>

>>>>> "Sanjoy" == Sanjoy Das <sanjoy@playingwithpointers.com> writes:

Sanjoy> +	  /* If the plugin specifically mentioned a parent block, we
Sanjoy> +	     use that */

The comment should end with a period and two spaces.

Sanjoy> +	  /* and if not, we set a default parent block. */

Similarly, and also the first letter should be capitalized.

Ok with those changes.

Tom

References:
- [PATCH 0/3] Fix recent breakage in the JIT reader interface
  - From: Sanjoy Das
- [PATCH 1/3] Fix http://sourceware.org/bugzilla/show_bug.cgi?id=14550
  - From: Sanjoy Das

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]