This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 2/2] Remove pass in skip_unwinder_tests
On 08/23/2012 06:51 PM, Pedro Alves wrote:
> Do we really need to replace gdb_test_multiple with send_gdb/gdb_expect?
No.
> gdb_test_multiple will only issue fails in the internal errors cases.
> I find it acceptable that see nothing most the time, and see a FAIL
> when something goes really really wrong. More acceptable than the
> timeouts we likely get with send_gdb/gdb_expect in the same really
> really wrong cases, that is.
I thought gdb_test_multiple contributes PASS to test summary by
mistake. Here is a new version, which only removes 'pass' and keep gdb_test_multiple there.
--
Yao
gdb/testsuite:
2012-08-23 Yao Qi <yao@codesourcery.com>
* lib/gdb.exp (skip_unwinder_tests): Remove pass.
---
gdb/testsuite/lib/gdb.exp | 6 ------
1 files changed, 0 insertions(+), 6 deletions(-)
diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
index 0b02f76..97e79af 100644
--- a/gdb/testsuite/lib/gdb.exp
+++ b/gdb/testsuite/lib/gdb.exp
@@ -2104,23 +2104,17 @@ proc skip_unwinder_tests {} {
set ok 1
gdb_test_multiple "print _Unwind_DebugHook" "check for unwinder hook" {
-re "= .*no debug info.*_Unwind_DebugHook.*\r\n$gdb_prompt $" {
- # Pass the test so we don't get bogus fails in the results.
- pass "check for unwinder hook"
set ok 0
}
-re "= .*_Unwind_DebugHook.*\r\n$gdb_prompt $" {
- pass "check for unwinder hook"
}
-re "No symbol .* in current context.\r\n$gdb_prompt $" {
- # Pass the test so we don't get bogus fails in the results.
- pass "check for unwinder hook"
set ok 0
}
}
if {!$ok} {
gdb_test_multiple "info probe" "check for stap probe in unwinder" {
-re ".*libgcc.*unwind.*\r\n$gdb_prompt $" {
- pass "check for stap probe in unwinder"
set ok 1
}
-re "\r\n$gdb_prompt $" {
--
1.7.7.6