This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 3/6] attach to command_option-changed observer.
On Tuesday, July 24, 2012 02:47:04 PM Tom Tromey wrote:
> Yao> + fprintf_unfiltered (mi->event_channel,
> Yao> + "option-changed,option=\"%s\",value=\"%s\"",
> Yao> + option, value);
>
> This has a quoting bug. VALUE can contain characters requiring special
> quoting for MI.
>
> I once wrote a patch to change the event channel to use ui-out:
>
> http://sourceware.org/ml/gdb-patches/2011-01/msg00518.html
>
> That would be one way to deal with the problem, but there are probably
> other ways as well. (I didn't commit that patch because Volodya had a
> different approach to emitting the notifications that I was interested
> in... but I still think it is a decent idea.)
Hi, Tom,
What is the different approach? I don't see any discussion in that thread.
What should we do here? Shall we keep using ui-file (as what I wrote in this
patch) or migrate to ui-out with your patch applied?
--
Yao (éå)