This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: 7.4->7.5 Regression gdb.base/pending.exp with gdbserver [Re: [PATCH] Dynamic printf for a target agent]
On Fri, 20 Jul 2012 04:27:59 +0200, Yao Qi wrote:
> It seems incorrect to remove "*dataptr != 'X'" out of this condition checking.
>
> With the breakpoint commands added, the Z packet becomes
>
> "Z0xxxxXxxxx,Xxxxx;cmds:xxxxx"
>
> When parsing this packet, in current (wrong) GDBserver, only the first
> condition ('Xxxxx') in packet is added, and the rest of conditions are skipped,
> which is a mistake.
xxxx may contain only hex bytes or ',' so it should be safe.
> 2012-07-20 Yao Qi <yao@codesourcery.com>
>
> * server.c (process_point_options): Stop at 'X' when parsing.
I find this change safe for check-in so OK.
Thanks for the fix,
Jan