This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 2/6] allow to suppress more mi notification

From: Tom Tromey <tromey at redhat dot com>
To: Yao Qi <yao at codesourcery dot com>
Cc: <gdb-patches at sourceware dot org>
Date: Tue, 24 Jul 2012 14:40:14 -0600
Subject: Re: [PATCH 2/6] allow to suppress more mi notification
References: <1343146252-22558-1-git-send-email-yao@codesourcery.com> <1343146252-22558-3-git-send-email-yao@codesourcery.com>

>>>>> "Yao" == Yao Qi <yao@codesourcery.com> writes:

Yao> 2012-07-24  Yao Qi  <yao@codesourcery.com>
Yao> 	* mi/mi-interp.c: Remove mi_suppress_breakpoint_notifications.
Yao> 	Define array mi_suppress_notification.
Yao> 	(mi_breakpoint_created): Update.
Yao> 	(mi_breakpoint_deleted): Likewise.
Yao> 	(mi_breakpoint_modified): Likewise.
Yao> 	* mi/mi-main.c (mi_cmd_execute): Likewise.
Yao> 	* mi/mi-main.h (enum MI_SUPRESS_NOTIFICATION): New.

Looks pretty good.  One nit...

Yao> +enum MI_SUPRESS_NOTIFICATION { MI_SUPPRESS_BREAKPOINT };

It is odd to use all caps for an enum tag name.

Ok with this changed.

Tom

References:
- [RFC 0/6] MI notification of command option change
  - From: Yao Qi
- [PATCH 2/6] allow to suppress more mi notification
  - From: Yao Qi

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]