This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [obv] Handle var_string_noescape and var_optional_filename together.
- From: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- To: Yao Qi <yao at codesourcery dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 18 Jul 2012 15:56:55 +0200
- Subject: Re: [obv] Handle var_string_noescape and var_optional_filename together.
- References: <1342636814-1674-1-git-send-email-yao@codesourcery.com>
On Wed, 18 Jul 2012 20:40:14 +0200, Yao Qi wrote:
> I notice that the code in case var_string_noescape and var_optional_filename
> are exactly the same, so this patch is to combine them together. I'll commit
> it in two days.
I do not agree, this will hide an existing bug.
Correct it to fix var_optional_filename to be more like var_filename (clearing
whitespaces + doing tilde_expand); except sure without that:
if (arg == NULL)
error_no_arg (_("filename to set it to."));
Thanks,
Jan