RE: [PATCH]Fix that GDB will get hang on Windows when using pipe to get stdout and stderr from stub

["Terry Guo" <terry dot guo at arm dot com>]

> 
> > diff --git a/gdb/ser-base.c b/gdb/ser-base.c
> > index 2f12dfc..152b1aa 100644
> > --- a/gdb/ser-base.c
> > +++ b/gdb/ser-base.c
> > @@ -25,6 +25,7 @@
> >
> >  #include "gdb_select.h"
> >  #include "gdb_string.h"
> > +#include "gdb_assert.h"
> >  #include <sys/time.h>
> >  #ifdef USE_WIN32API
> >  #include <winsock2.h>
> > @@ -242,6 +243,64 @@ ser_base_wait_for (struct serial *scb, int
> timeout)
> >      }
> >  }
> >
> > +/* Read any error output we might have.  */
> > +
> > +static void
> > +ser_base_read_error_fd (struct serial *scb, int close_fd)
> > +{
> > +  if (scb->error_fd != -1)
> > +    {
> > +      ssize_t s;
> > +      char buf[GDB_MI_MSG_WIDTH + 1];
> > +
> > +      for (;;)
> > +        {
> > +         char *current;
> 
> I notice you are not following the convention of converting 8 spaces to
> a TAB character here and everywhere else.  Can you please fix it?
> After
> that, I can commit the patch for (if you don't have the permission yet).
> 

Hello Sergio,

Can you help to review the attached patch which should convert 8 spaces to a
TAB? Thanks.
BTW. I think I have write permission now.

BR,
Terry

Attachment: gdb-hang-v2.patch
Description: Binary data