This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[commit] testsuite: racy gdb.base/dprintf.exp (PR 12649)


Hi Stan,

 set dprintf-style agent^M
-warning: Target cannot run dprintf commands, falling back to GDB printf^M
-warning: Target cannot run dprintf commands, falling back to GDB printf^M
-(gdb) PASS: gdb.base/dprintf.exp: Set dprintf style to agent - cannot do
+warning: Target cannot run dprintf commands, falling back to GDB printfPASS: gdb.base/dprintf.exp: Set dprintf style to agent - cannot do
 set dprintf-style foobar^M
-Undefined item: "foobar".^M
-(gdb) PASS: gdb.base/dprintf.exp: Set dprintf style to an unrecognized type
+^M
+warning: Target cannot run dprintf commands, falling back to GDB printf^M
+(gdb) FAIL: gdb.base/dprintf.exp: Set dprintf style to an unrecognized type

It is also reliably reproducible with 'read1' from:
	reproducer for races of expect incomplete reads
	http://sourceware.org/bugzilla/show_bug.cgi?id=12649

Checked in.


Regards,
Jan


http://sourceware.org/ml/gdb-cvs/2012-07/msg00032.html

--- src/gdb/testsuite/ChangeLog	2012/07/04 11:28:03	1.3274
+++ src/gdb/testsuite/ChangeLog	2012/07/04 14:57:22	1.3275
@@ -1,3 +1,9 @@
+2012-07-04  Jan Kratochvil  <jan.kratochvil@redhat.com>
+
+	PR 12649
+	* gdb.base/dprintf.exp (Set dprintf style to agent): Add missing
+	gdb_test_multiple $gdb_prompt terminator.
+
 2012-07-04  Pedro Alves  <palves@redhat.com>
 
 	* gdb.mi/mi-reverse.exp: Use supports_reverse and
--- src/gdb/testsuite/gdb.base/dprintf.exp	2012/07/02 15:29:39	1.4
+++ src/gdb/testsuite/gdb.base/dprintf.exp	2012/07/04 14:57:23	1.5
@@ -88,7 +88,7 @@
 set target_can_dprintf 1
 set msg "Set dprintf style to agent"
 gdb_test_multiple "set dprintf-style agent" $msg {
-    -re "warning: Target cannot run dprintf commands.*" {
+    -re "warning: Target cannot run dprintf commands.*\r\n$gdb_prompt $" {
 	set target_can_dprintf 0
 	pass "$msg - cannot do"
     }


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]