This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] Support bionic's jmp_buf.


On 6/25/2012 10:54 AM, Thiago Jung Bauermann wrote:
Hello,

On Mon, 2012-06-25 at 21:32 +0800, Yao Qi wrote:
On Sunday, June 24, 2012 06:46:15 PM Thiago Jung Bauermann wrote:
+/* Determines whether the inferior is an Android application.  */
+
+static int
+is_target_linux_android (void)
Looks this function is not arm-specific, so we can move it to linux-tdep.c.
Thanks for your review.

Android is officially supported on ARM and x86. I don't know how GDB
fares on Android on x86, and at least for now it will only be used on
ARM (I don't have plans to work on Android on x86).

With that said, I'm happy to move to linux-tdep.c if that makes more
sense. I'll do the change before I commit or on the next iteration of
the patch if there is one.

Looking at the original patch, the code is not required for bionic on x86.
Yet, to have this function in a shared location might make it easier to code dependencies in the future.


- Fabian


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]