This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Suppress stap-trace.exp when compilation fails
- From: Pedro Alves <palves at redhat dot com>
- To: Keith Seitz <keiths at redhat dot com>
- Cc: "gdb-patches at sourceware dot org ml" <gdb-patches at sourceware dot org>
- Date: Wed, 23 May 2012 18:37:02 +0100
- Subject: Re: [RFA] Suppress stap-trace.exp when compilation fails
- References: <4FBD1B16.7080606@redhat.com>
On 05/23/2012 06:15 PM, Keith Seitz wrote:
> Hi,
>
> stap-trace.exp does not check the return value of its compile-a-testcase wrapper procedure, so when compilation of the test case fails, it attempts to run the tests anyway instead of nicely bailing out.
>
> This patch addresses this by fixing the compile wrapper to always return a valid value and checking this procedure's return value before running the tests.
>
> Okay?
Sure, thanks. There's a second compilation further below, but I'll assume that if
the first succeeds, the second should also.
--
Pedro Alves