This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: MIPS Linux signals


On 05/21/2012 03:48 PM, Maciej W. Rozycki wrote:
On Mon, 21 May 2012, Michael Eager wrote:

BTW, I wouldn't bother with gdbarch_target_signal_to_host.  Nothing ever
calls it.

I hadn't noticed that. I thought that it was called to translate the signal number when sent to the target. Instead, target_signal_to_host() is called.

Shall we drop the unused gdbarch API so as to avoid further confusion then? Shouldn't target_signal_from_host be renamed to something closer to what it really does, e.g. signal_from_target? It's not that host signals really ever matter unless host == target in which case they're still target signals too (this observation applies to gdbserver as well).

This would be OK with me. The gdbarch_target_signal_to_host interface suggests that this should differ for different targets.

There is an old bug report about the unclear name for the function.
gdbarch_signal_from_target would be a better name.

--
Michael Eager	 eager@eagercon.com
1960 Park Blvd., Palo Alto, CA 94306  650-325-8077


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]