This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [commit] Do not rely on FIELD_LOC_KIND_BITPOS being zero

From: Tom Tromey <tromey at redhat dot com>
To: Jan Kratochvil <jan dot kratochvil at redhat dot com>
Cc: Pedro Alves <palves at redhat dot com>, gdb-patches at sourceware dot org, Siddhesh Poyarekar <siddhesh at redhat dot com>
Date: Tue, 17 Apr 2012 08:20:58 -0600
Subject: Re: [commit] Do not rely on FIELD_LOC_KIND_BITPOS being zero
References: <20120417124410.GA15356@host2.jankratochvil.net> <4F8D695E.7070002@redhat.com> <20120417131559.GA25248@host2.jankratochvil.net>

>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:

Pedro> We could make the compiler catch these by making the macro return
Pedro> an rvalue.

Yes, please do it.  If there is a setter we should make the getter an
rvalue when possible.

Jan> With C++ getters and constructors-with-parameters such problem would have
Jan> never exist.

Also true :)

Tom

References:
- [commit] Do not rely on FIELD_LOC_KIND_BITPOS being zero
  - From: Jan Kratochvil
- Re: [commit] Do not rely on FIELD_LOC_KIND_BITPOS being zero
  - From: Pedro Alves
- Re: [commit] Do not rely on FIELD_LOC_KIND_BITPOS being zero
  - From: Jan Kratochvil

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]