This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 11/15] Don't check $ after gdb_prompt.


On Wed, Apr 11, 2012 at 11:28 PM, Yao Qi <yao@codesourcery.com> wrote:
> gdb/testsuite:
>
> 2012-03-15 ?Yao Qi ?<yao@codesourcery.com>
>
> ? ? ? ?* lib/gdbserver-support.exp (gdb_target_cmd): Don't check $ after
> ? ? ? ?gdb_prompt.
> ---
> ?gdb/testsuite/lib/gdbserver-support.exp | ? ?4 ++++
> ?1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/gdb/testsuite/lib/gdbserver-support.exp b/gdb/testsuite/lib/gdbserver-support.exp
> index ee66e48..f5aa6ea 100644
> --- a/gdb/testsuite/lib/gdbserver-support.exp
> +++ b/gdb/testsuite/lib/gdbserver-support.exp
> @@ -69,6 +69,10 @@ proc gdb_target_cmd { targetname serialport } {
> ? ? ? ? ? ? ? ?verbose "Set target to $targetname"
> ? ? ? ? ? ? ? ?return 0
> ? ? ? ? ? ?}
> + ? ? ? ? ? -re "Remote debugging using .*$serialport_re.*$gdb_prompt " {
> + ? ? ? ? ? ? ? verbose "Set target to $targetname (async)"
> + ? ? ? ? ? ? ? return 0
> + ? ? ? ? ? }
> ? ? ? ? ? ?-re "Remote debugging using stdio.*$gdb_prompt $" {
> ? ? ? ? ? ? ? ?verbose "Set target to $targetname"
> ? ? ? ? ? ? ? ?return 0

Hi.
Either the stdio case needs similar treatment, or we should fold the
stdio case into serialport_re.
Before we do that though, does this patch have the intended effect?
I'm not up on the precise details of expect pattern matching, but I'd
appreciate an explanation of why this is needed.
Thanks.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]