This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] find_partial_die cleanups
On Mon, Apr 9, 2012 at 11:16 AM, Tom Tromey <tromey@redhat.com> wrote:
> Doug> + ? error (_("Dwarf Error: Type Unit at offset 0x%lx contains"
> Doug> + ? ? ? ? ? ?" external reference to offset 0x%lx [in module %s].\n"),
> Doug> + ? ? ? ? ?(long) cu->header.offset.sect_off, (long) offset.sect_off,
> Doug> + ? ? ? ? ?bfd_get_filename (objfile->obfd));
>
> Why an error and not a complaint?
>
> I ask because errors have a pretty drastic effect on debuginfo reading.
"Right on queue." :-)
Indeed. And I would have used a complaint but the callers aren't
expecting a NULL return and since there is ample precedent, I went
with error.
I'm happy to go throught all the callers and bubble up the
consequences, but my first pass at this gave me pause.
> Doug> + ? ? ?struct dwarf2_section_info* sec;
>
> Wrong "*" placement.
Heh, righto.