This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [commit] dwarf2read.c (load_partial_dies): Change condition to assert.

From: Doug Evans <dje at google dot com>
To: Michael Eager <eager at eagerm dot com>
Cc: gdb-patches at sourceware dot org
Date: Sat, 7 Apr 2012 13:49:39 -0700
Subject: Re: [commit] dwarf2read.c (load_partial_dies): Change condition to assert.
References: <20120407193915.4B21224618E@ruffy.mtv.corp.google.com> <4F80A628.7050304@eagerm.com>

On Sat, Apr 7, 2012 at 1:40 PM, Michael Eager <eager@eagerm.com> wrote:
> On 04/07/2012 12:39 PM, Doug Evans wrote:
>>
>> Hi.
>>
>> There's no caller where cu->per_cu == NULL,
>> and I'd rather have the assert.
>
>
> Per_cu data is flushed asynchronously in free_heap_comp_unit()
> and free_stack_comp_unit(). ?Are you sure that this can't happen?

Define "asynchronously".

My reading of all of the callers says it can't happen (modulo bugs of course).
I could have missed something of course (in which case let's get
something added to the testsuite to exercise the appropriate code
path).

Follow-Ups:
- Re: [commit] dwarf2read.c (load_partial_dies): Change condition to assert.
  - From: Michael Eager

References:
- [commit] dwarf2read.c (load_partial_dies): Change condition to assert.
  - From: Doug Evans
- Re: [commit] dwarf2read.c (load_partial_dies): Change condition to assert.
  - From: Michael Eager

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]