This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA 1/2] Linespec rewrite (update 2)
- From: Doug Evans <dje at google dot com>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: Keith Seitz <keiths at redhat dot com>, "gdb-patches at sourceware dot org ml" <gdb-patches at sourceware dot org>
- Date: Thu, 5 Apr 2012 08:54:33 -0700
- Subject: Re: [RFA 1/2] Linespec rewrite (update 2)
- References: <4F70F8F7.503@redhat.com> <87zkb0wj1x.fsf@fleche.redhat.com> <4F74B583.6090008@redhat.com> <87obrertls.fsf@fleche.redhat.com> <4F75D859.1010907@redhat.com> <87r4waqc38.fsf@fleche.redhat.com> <20120330170913.GT2701@adacore.com> <87fwcqq8gl.fsf@fleche.redhat.com> <4F75F5F5.8070105@redhat.com> <4F7B8610.9070302@redhat.com> <87hawygq65.fsf@fleche.redhat.com>
On Thu, Apr 5, 2012 at 8:21 AM, Tom Tromey <tromey@redhat.com> wrote:
>>>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes:
>
> Keith> Given Doug's comments earlier today, I'm reposting anything that
> Keith> hasn't already been approved or which changed. The easiest way to see
> Keith> what's happened is, of course, by inspecting the commit history of the
> Keith> branch.
>
> Keith> I'll follow-up separately with the other patch that was updated.
>
> I have no further comments. ?I think it looks great.
>
> I think at this point you just need Doug's ok.
All I had were nits, so 'tis ok with me.