This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 008/238] Fix Wshadow
- From: Andrey Smirnov <andrew dot smirnov at gmail dot com>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 30 Mar 2012 09:35:45 -0700
- Subject: Re: [PATCH 008/238] Fix Wshadow
- References: <1322398359-1364-1-git-send-email-andrew.smirnov@gmail.com> <20120329223512.GR2701@adacore.com>
On Thu, Mar 29, 2012 at 3:35 PM, Joel Brobecker <brobecker@adacore.com> wrote:
>> ?2011-11-19 ?Andrey Smirnov <andrew.smirnov@gmail.com>
>>
>> + ? ? * ada-lang.c (ada_make_symbol_completion_list): Rename
>> + ? ? `wild_match' to `wild_match_p'(-Wshadow).
>> +
>> +2011-11-19 ?Andrey Smirnov <andrew.smirnov@gmail.com>
> [...]
>> - ?int wild_match;
>> + ?int wild_match_p;
>
> The code has changed since you submitted this patch. I am going to
> work on a new set of patches that fix this particular type of
> warnings... Forgive me if I do not respond to each of the patches
> that fix this problem.
Yes, unfortunately my patch-set has bit-rotted significantly since the
time I submitted the
patches and the fact that I used git and the main codebase is in CVS
doesn't help either.
I wish I had more time to actually go through the code and convert it
to be compatible with the new codebase,
but unfortunately right now I do not.
Best of luck in your endeavor. Hope my old patches would be at least
marginally helpful to you.
Andrey Smirnov