This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch#2 3/6] set auto-load local-gdbinit warn-and-*
- From: Eli Zaretskii <eliz at gnu dot org>
- To: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 30 Mar 2012 10:25:41 +0300
- Subject: Re: [patch#2 3/6] set auto-load local-gdbinit warn-and-*
- References: <20120329091258.GD25449@host2.jankratochvil.net>
- Reply-to: Eli Zaretskii <eliz at gnu dot org>
> Date: Thu, 29 Mar 2012 11:12:58 +0200
> From: Jan Kratochvil <jan.kratochvil@redhat.com>
>
> it does not change any default behavior (that's done in [patch 6/6]) but it
> gives an option to warn on .gdbinit files (which become deprecated).
Thanks.
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -141,7 +141,7 @@ set auto-load python-scripts on|off
> show auto-load python-scripts
> Control auto-loading of Python script files.
>
> -set auto-load local-gdbinit on|off
> +set auto-load local-gdbinit on|off|warn-and-on|warn-and-off
> show auto-load local-gdbinit
> Control loading of init file (.gdbinit) from current directory.
OK.
> If enabled, canned sequences of commands are loaded when debugger starts\n\
> from .gdbinit file in current directory. Such files are deprecated,\n\
> use script associated with inferior executable file instead.\n\
^^^^^^^^^^
Either "use a script" or "use scripts", probably the former.
> --- a/gdb/doc/gdb.texinfo
> +++ b/gdb/doc/gdb.texinfo
> @@ -1287,13 +1287,16 @@ Processes command line options and operands.
> @item
> Reads and executes the commands from init file (if any) in the current
> working directory as long as @samp{set auto-load local-gdbinit} is set to
> -@samp{yes} (@pxref{Current Directory Init File}).
> +@samp{yes} or @samp{warn-and-yes} (@pxref{Current Directory Init File}).
> This is only done if the current directory is
> different from your home directory. Thus, you can have more than one
> init file, one generic in your home directory, and another, specific
> to the program you are debugging, in the directory where you invoke
> @value{GDBN}.
>
> +This feature is deprecated, please use @ref{objfile-gdb.rc file} instead;
"objfile" should be in @var, and it should explain what is "objfile".
> gdb-scripts: Canned sequences of commands auto-loading is on.
> libthread-db: Inferior specific libthread_db auto-loading is on.
> -local-gdbinit: Current directory .gdbinit script auto-loading is on.
> +local-gdbinit: Current directory .gdbinit script auto-loading is yes.
Why "yes"?
> +as the @samp{local-gdbinit} feature is deprecated in the favor
"in favor", without "the".
> +of @xref{objfile-gdb.rc file}.
Again, "objfile" should be in @var.
OK with those changes.
> + warning (_("Reading file .gdbinit in current directory but it "
> + "has been deprecated and the reading will be "
> + "removed. %s"),
"reading will be removed" is very ambiguous. Suggest something like
Reading of .gdbinit files in current directory has been deprecated
and will be removed in a future version of GDB.