This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[commit 09/12] Rename "encoded" parameter in ada-lang.c:symbol_completion_match...
- From: Joel Brobecker <brobecker at adacore dot com>
- To: gdb-patches at sourceware dot org
- Cc: Joel Brobecker <brobecker at adacore dot com>
- Date: Thu, 29 Mar 2012 16:33:32 -0700
- Subject: [commit 09/12] Rename "encoded" parameter in ada-lang.c:symbol_completion_match...
- References: <1333064015-29503-1-git-send-email-brobecker@adacore.com>
... This is mostly to be consistent with the style used for the other
parameter of the same kind ("wild_match_p") in that function.
gdb/ChangeLog:
* ada-lang.c (symbol_completion_match): Rename parameter
"encoded" into "encoded_p". Ajust code and documentation
accordingly.
---
gdb/ChangeLog | 6 ++++++
gdb/ada-lang.c | 8 ++++----
2 files changed, 10 insertions(+), 4 deletions(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 91052a0..9a6e55d 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,4 +1,10 @@
2012-03-29 Joel Brobecker <brobecker@adacore.com>
+
+ * ada-lang.c (symbol_completion_match): Rename parameter
+ "encoded" into "encoded_p". Ajust code and documentation
+ accordingly.
+
+2012-03-29 Joel Brobecker <brobecker@adacore.com>
Andrey Smirnov <andrew.smirnov@gmail.com>
-Wshadow warning fix.
diff --git a/gdb/ada-lang.c b/gdb/ada-lang.c
index f68207b..64fb848 100644
--- a/gdb/ada-lang.c
+++ b/gdb/ada-lang.c
@@ -5641,13 +5641,13 @@ ada_add_block_symbols (struct obstack *obstackp,
TEXT_LEN is equal to the length of TEXT.
Perform a wild match if WILD_MATCH_P is set.
- ENCODED should be set if TEXT represents the start of a symbol name
+ ENCODED_P should be set if TEXT represents the start of a symbol name
in its encoded form. */
static const char *
symbol_completion_match (const char *sym_name,
const char *text, int text_len,
- int wild_match_p, int encoded)
+ int wild_match_p, int encoded_p)
{
const int verbatim_match = (text[0] == '<');
int match = 0;
@@ -5664,7 +5664,7 @@ symbol_completion_match (const char *sym_name,
if (strncmp (sym_name, text, text_len) == 0)
match = 1;
- if (match && !encoded)
+ if (match && !encoded_p)
{
/* One needed check before declaring a positive match is to verify
that iff we are doing a verbatim match, the decoded version
@@ -5714,7 +5714,7 @@ symbol_completion_match (const char *sym_name,
if (verbatim_match)
sym_name = add_angle_brackets (sym_name);
- if (!encoded)
+ if (!encoded_p)
sym_name = ada_decode (sym_name);
return sym_name;
--
1.7.1