This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA 1/2] Linespec rewrite (update 2)


On 03/27/2012 08:05 AM, Joel Brobecker wrote:
I am almost done with the extension of operator_bp.exp; I'll send it
when I've removed all the typos and thinkos...

Here it is... As expected, it fails on HEAD, so cannot commit just yet. But PASSes with your previous iteration of the patch series, and now fails...

If it is failing on the "unimplemented" message, we can certainly whack that from the patch -- it doesn't affect test results at all. In fact, I've pushed this. The decision to issue an unimplemented error should really come from create_linespec_from_sals, since that is the function that actually does the work, and if mi/13139 ever gets implemented, this will affect that as well.


I am worried that it appears to give a false positive on your tests with no indication that anything has gone awry. [I worry because I intended to actually implement symbol-relative offsets sometime in the future.]

Keith


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]