This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Add autoload-breakpoints [7/7] autoload-breakpoints doc


Hi Eli,

Thanks for your review.

On 03/24/12 21:57, Eli Zaretskii wrote:
Date: Wed, 21 Mar 2012 18:57:26 +0800
From: Hui Zhu<hui_zhu@mentor.com>
CC:<gdb-patches@sourceware.org>,<stan_shebs@mentor.com>

I post a patch that updated according to your comments.  Please help me
review it.

Below.


+Prior to @value{GDBN} connects to remote stub, some breakpoints might
+have been already set in target, either by a prior GDB session or
                                                       ^^^
@value{GDBN}

+remote stub. We call these breakpoints as "auotload-breakpoints".
                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   We call these breakpoints @dfn{auotload-breakpoints}.

+We believe such reliable report is useful to GDB, and generalize it,
+called "ReportAsync".

We call these asynchronous reports about changes in the remote-side breakpoints @dfn{ReportAsync}.

+The connection between "ReportAsync" and "autoload-breakpoints" is when
+inferior/stub add/set/delete breakpoints, sends async report to GDB about
+added/set/removed breakpoints.

This sentence adds nothing to what already has been said. Please remove it.

+how to handle the autoload-breakpints when @value{GDBN} connect to the stub.
                               ^^^^^^^^^^
A typo.

+@cindex Autoload-breakpoints Format

Lower-case "autoload" and "format", please.


+this packet through reportAsync Packets.
                        ^^^^^^^^^^^
"ReportAsync", with a capital R.

OK with these changes.

Thanks.

I post a new version patch according to your comments.


Best,
Hui

2012-03-26 Hui Zhu <hui_zhu@mentor.com>

	* gdb.texinfo (Setting Breakpoints): Add set breakpoint autoload.
	(Remote Serial Protocol): Add Autoload-breakpoints Format.

Attachment: autoload-breakpoints-doc.txt
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]