This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Finalizing fix committed for "[PATCH] sim: make sure to include strsignal prototype"


On Saturday 24 March 2012 06:55:28 Hans-Peter Nilsson wrote:
> This patch was missing the critical include of cconfig.h so you
> should still have seen warnings about implicit declarations of
> strsignal when testing.

as i mentioned earlier, there are no warnings for me because my glibc conforms 
to the 2008 POSIX spec

> I built and and started testing for bfin-elf+unix but got a lot
> of assembly errors for values out-of-range (HEAD binutils,
> perhaps the assembler isn't tested on a 32-bit host?)

should work, but i'll build it up to see

> assembly-code tests and also apparently a compiler is not
> optional as for cris-sim, but required, causing spurious errors.

if i knew how to make it optional, i would have them auto-skipped ;)

> FWIW, all sim tests fail linking for cr16-elf+cr16-sim, maybe my
> locally added baseboard is out of date.

http://sourceware.org/bugzilla/show_bug.cgi?id=12385

> --- nrun.c	24 Mar 2012 05:38:35 -0000	1.17
> +++ nrun.c	24 Mar 2012 09:31:09 -0000	1.18
> 
> +/* Need to be before general includes, to pick up e.g. _GNU_SOURCE.  */
> +#ifdef HAVE_CONFIG_H
> +#include "cconfig.h"
> +#include "tconfig.h"
> +#endif

the cconfig.h makes sense, but i don't think the tconfig.h does
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]