This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] sim: make sure to include strsignal prototype
- From: Hans-Peter Nilsson <hp at bitrange dot com>
- To: Mike Frysinger <vapier at gentoo dot org>
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 23 Mar 2012 01:24:07 -0400 (EDT)
- Subject: Re: [PATCH] sim: make sure to include strsignal prototype
- References: <1332476592-12930-1-git-send-email-vapier@gentoo.org>
On Fri, 23 Mar 2012, Mike Frysinger wrote:
> Before POSIX standardized strsignal(), old systems would hide the
> prototype unless the normal extension defines were enabled. So use
> the AC_USE_SYSTEM_EXTENSIONS helper for that.
>
> Then make sure we include string.h ourselves in nrun.c rather than
> relying on implicit includes via other sim headers.
>
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
>
> sim/common/:
> 2012-03-23 Mike Frysinger <vapier@gentoo.org>
>
> * acinclude.m4 (SIM_AC_COMMON): Call AC_USE_SYSTEM_EXTENSIONS.
> * nrun.c: Include string.h/strings.h.
> * aclocal.m4, config.in, configure: Regenerate.
>
> sim/arm:
> sim/bfin:
> sim/avr:
> sim/d10v:
> sim/cr16:
> sim/cris:
> sim/erc32:
> sim/frv:
> sim/h8300:
> sim/iq2000:
> sim/m32c:
> sim/m32r:
> sim/lm32:
> sim/m68hc11:
> sim/microblaze:
> sim/mcore:
> sim/mips:
> sim/mn10300:
> sim/moxie:
> sim/rl78:
> sim/rx:
> sim/sh64:
> sim/sh:
> sim/v850:
> 2012-03-23 Mike Frysinger <vapier@gentoo.org>
>
> * aclocal.m4, config.in, configure: Regenerate.
>
> sim/igen:
> sim/ppc:
> sim/testsuite:
> 2012-03-23 Mike Frysinger <vapier@gentoo.org>
>
> * configure: Regenerate.
Ok thanks. I noticed your later comments regarding ppc/ and
testsuite/, but better regenerated now even if it's because of
earlier changes than noise later. (And the "regenerate" is still
true even it the reason wasn't your changes.)
Another thing I noticed: could you please adjust the
sim/testsuite/sim/cris/c/ tests too? Lots of "program stopped
with signal" there; your earlier fixes seems to have been just
to the asm/ subdir. I'm not putting it on you to assemble a
cris-elf toolchain to verify it (not that it shouldn't be
obvious :) just do the same transformation as in asm/.
Thanks.
brgds, H-P