This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA/Ada] Crash when trying to set value of packed array element
On Fri, Mar 16, 2012 at 07:11:40PM +0100, Jan Kratochvil wrote:
> On Fri, 16 Mar 2012 18:59:33 +0100, Joel Brobecker wrote:
> > > > - CORE_ADDR new_addr;
> > > > + long new_offset = offset;
> > >
> > > Nitpick - LONGEST (Siddhesh Poyarekar is working on a more thorough fix).
> >
> > I know you said it's a nitpick, but I don't understand why you think
> > it should be LONGEST. "offset" itself is a long, and the only use
> > of that new_offset is for set_value_offset, which takes an int. Are
> > the changes you are referring to going to make that a LONGEST?
>
> Yes; not sure if in the first phase but I hope so.
Yes, offset has been expanded to LONGEST in the first phase patch.
--
Siddhesh