This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA 2/2] Varobj support for Ada.
- From: Joel Brobecker <brobecker at adacore dot com>
- To: gdb-patches at sourceware dot org
- Date: Fri, 16 Mar 2012 18:26:37 -0700
- Subject: Re: [RFA 2/2] Varobj support for Ada.
- References: <1330555268-32692-1-git-send-email-brobecker@adacore.com> <1330555268-32692-3-git-send-email-brobecker@adacore.com> <87mx80do26.fsf@fleche.redhat.com> <20120315213637.GR2853@adacore.com>
> I also have to look at documentation and NEWS...
Attached are two patches. The first one provide a small update to
the documentation, bringing a clarification that was suggested in
patch #1 ...
Re: [RFA 1/2] framework for varobj type mutation
http://www.sourceware.org/ml/gdb-patches/2012-03/msg00043.html
> Joel> + v->to = -1; /* FIXME: Is that necessary? */
> Joel> + v->from = -1;
>
> This seems mildly iffy, since it changes the var update range "behind
> the user's back". I understand why you'd do it, though.
>
> This should at least be documented.
... and the fact that children of varobjs whose type have changed
are deleted.
The second patch is a NEWS entry just announcing support for Ada
in GDB/MI Variable Objects.
gdb/doc/ChangeLog:
* gdb.texinfo (GDB/MI Variable Objects): Document what happens
to the children of a varobj and its update range when -var-update
returns that the varobj's type changed.
gdb/ChangeLog:
* NEWS: Add entry for Ada varobj support.
The gdb.texinfo change was tested by re-generating the documentation
in all formats.
OK to apply?
Thanks,
--
Joel
>From 385fa3ecd3b58cbba0753997010990cbfd662bb8 Mon Sep 17 00:00:00 2001
From: Joel Brobecker <brobecker@adacore.com>
Date: Fri, 16 Mar 2012 17:58:08 -0700
Subject: [PATCH 1/2] [doco] document the "type_changed" flag further.
gdb/doc/ChangeLog:
* gdb.texinfo (GDB/MI Variable Objects): Document what happens
to the children of a varobj and its update range when -var-update
returns that the varobj's type changed.
---
gdb/doc/gdb.texinfo | 6 ++++++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
index 56bf5d5..69d12f4 100644
--- a/gdb/doc/gdb.texinfo
+++ b/gdb/doc/gdb.texinfo
@@ -29287,6 +29287,12 @@ This is only present if the varobj is still valid. If the type
changed, then this will be the string @samp{true}; otherwise it will
be @samp{false}.
+When a varobj's type changes, its children are also likely to have
+become irrelevant. As such, the varobj's children are automatically
+deleted when this attribute is @samp{true}. Also, he varobj's update
+range, when set using the @code{-var-set-update-range} command, is
+unset.
+
@item new_type
If the varobj's type changed, then this field will be present and will
hold the new type.
--
1.7.1
>From d30aa3dfc440944bd7e3018379fab5ecf25323d3 Mon Sep 17 00:00:00 2001
From: Joel Brobecker <brobecker@adacore.com>
Date: Fri, 16 Mar 2012 18:19:39 -0700
Subject: [PATCH 2/2] [NEWS] Announce support for Ada varobj support.
gdb/ChangeLog:
* NEWS: Add entry for Ada varobj support.
---
gdb/NEWS | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/gdb/NEWS b/gdb/NEWS
index e6bf59c..caa7b68 100644
--- a/gdb/NEWS
+++ b/gdb/NEWS
@@ -73,6 +73,8 @@
the ability to set breakpoints on inlined functions will be lost
in symbol files with older .gdb_index sections.
+* Ada support for GDB/MI Variable Objects has been added.
+
* New commands
** "catch load" and "catch unload" can be used to stop when a shared
--
1.7.1