This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [windows] patch to set breakpoint in a dll


On 2012-3-17 6:23, Doug Evans wrote:
On Thu, Mar 15, 2012 at 6:52 PM, asmwarrior<asmwarrior@gmail.com> wrote:
>  Ok, this is the new patch.(I have problem using the TortoiseGit to generate
>  a diff between two revisions.you can see, the file name is long and dirty)
>
>
>  Also, the log message is what you wrote:
>
>
>  2012-03-14  Zhang Yuanhui<asmwarrior@gmail.com>
>
>      * source.c (find_and_open_source): Consistently pass resulting
>      full path through xfullpath.
>
>
>  My family name is "Zhang", so I'm not sure it should be put before the given
>  name or after the given name. The Chinese name and English name have
>  different formats.
I say it's your choice. I just copied from an existing example in ChangeLog.
OK, please use the conversion Yuanhui Zhang which is similar to some gdb developers like: Hui Zhu and Yao Qi.
Heh. One last nit. Blank line between these two lines.

+       char *lpath;
+       lpath = xfullpath (*fullname);

[or combine them, but then you still need a blank line afterwards]

Can you check the patch in?  I'm happy to for you if necessary (at
which point I can just insert the blank line before checkin).
Thanks, I have no cvs write access, so please help me to check in by fixing the tiny nit.

Yuanhui Zhang

PS: resend the email to gdb patches maillist by using the plain text format.



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]