This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Use sized types in tracepoint.

From: Pedro Alves <palves at redhat dot com>
To: Mark Kettenis <mark dot kettenis at xs4all dot nl>
Cc: yao at codesourcery dot com, gdb-patches at sourceware dot org
Date: Fri, 16 Mar 2012 15:57:36 +0000
Subject: Re: [PATCH] Use sized types in tracepoint.
References: <1331905618-2631-1-git-send-email-yao@codesourcery.com> <201203161550.q2GFoQhS029855@glazunov.sibelius.xs4all.nl>

On 03/16/2012 03:50 PM, Mark Kettenis wrote:

> We have gnulib/stdint.h so using typedefs like int32_t should be ok.

GDBserver doesn't use gnulib, unfortunately.  Thought, it looks like
the Linux, Windows and Lynx backends already unconditionally include stdint.h.
The NTO backend doesn't, so I'm not sure if we can include it unconditionally.

On 03/16/2012 01:46 PM, Yao Qi wrote:
> +#include <inttypes.h>
>  #if HAVE_STDINT_H
       ^^^^^^^^^^^^^
>  #include <stdint.h>
>  #endif

So I'd like to see that HAVE_STDINT_H removed first.  If this causes
trouble, the option would be for gdbserver to use gnulib proper.

-- 
Pedro Alves

References:
- [PATCH] Use sized types in tracepoint.
  - From: Yao Qi
- Re: [PATCH] Use sized types in tracepoint.
  - From: Mark Kettenis

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]