This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

RE: [RFA] Fix mingw64 compilation



> -----Message d'origine-----
> De?: gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Pedro Alves
> Envoyé?: vendredi 16 mars 2012 11:27
> À?: Pierre Muller
> Cc?: gdb-patches@sourceware.org
> Objet?: Re: [RFA] Fix mingw64 compilation
> 
> On 03/16/2012 10:17 AM, Pierre Muller wrote:
> 
> > One more native target
> > that was not yet fixed for -Wmissing-prototypes
> > option.
> >
> > This is a simple adaptation of what
> > is in i386-windows-nat.c.
> >
> > I didn't use OBVIOUS rule
> > as I don't know if there was a 'better'
> > comment to put before...
> 
> 
> If it was good for i386-windows-nat.c, then this should be good.
> If it wasn't, then whoever wants to change it can change both
> i386-windows-nat.c and amd64-windows-nat.c at the same time in
> a follow up patch, using just about the same effort as just
> changing i386-windows-nat.c now.
> 
> IOW, just go ahead and commit this to fix the build.
You are of course right,
I committed this patch.

Thanks for the approval,

Pierre


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]