This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[PATCH v3] Add dll trampoline code handling for windows 64bit


Hi,

I hope this is the last round on this...

> Kai Tietz read this patch -- he says "hello" and asked me to respond.
>
> Roland> + struct minimal_symbol *indsym =
> Roland> + indirect ? lookup_minimal_symbol_by_pc (pc + indirect) : 0;
>
> Kai says that PC-relative expressions are relative to the end of the
> instruction. So, 'pc + indirect' is incorrect here and also in the
> read_memory call.
Oh man! I couldn't see the forest for the trees.
While my previous approach was in the end correctly working this is
the cleaner solution. That way read_memory_unsigned_integer()
can be used now, delivering correct results.


ChangeLog:

2012-03-16 Roland Schwingel <roland.schwingel@onevision.com>

        * amd64-windows-tdep.c: #include "frame.h".
        (amd64_windows_skip_trampoline_code): New function.
        (amd64_windows_init_abi): Add trampoline registration.

Roland

Attachment: amd64-windows-tdep.c.patch
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]