This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v2] Add dll trampoline code handling for windows 64bit


>>>>> "Roland" == Roland Schwingel <roland@onevision.com> writes:

Roland> Here is a new version of my patch from yesterday. I took
Roland> (hopefully correct) all suggestions regarding formatting and
Roland> indention into account.

It seems ok to me.

Roland> I can't use the gdb read_memory functions here that do
Roland> endianness conversion.

Kai Tietz read this patch -- he says "hello" and asked me to respond.

Roland> +      struct minimal_symbol *indsym =
Roland> +        indirect ? lookup_minimal_symbol_by_pc (pc + indirect) : 0;

Kai says that PC-relative expressions are relative to the end of the
instruction.  So, 'pc + indirect' is incorrect here and also in the
read_memory call.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]