This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2] Add dll trampoline code handling for windows 64bit
- From: Tom Tromey <tromey at redhat dot com>
- To: Roland Schwingel <roland at onevision dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Thu, 15 Mar 2012 09:38:16 -0600
- Subject: Re: [PATCH v2] Add dll trampoline code handling for windows 64bit
- References: <4F609EB7.2020801@onevision.com> <4F62032B.3000907@onevision.com>
>>>>> "Roland" == Roland Schwingel <roland@onevision.com> writes:
Roland> Here is a new version of my patch from yesterday. I took
Roland> (hopefully correct) all suggestions regarding formatting and
Roland> indention into account.
It seems ok to me.
Roland> I can't use the gdb read_memory functions here that do
Roland> endianness conversion.
Kai Tietz read this patch -- he says "hello" and asked me to respond.
Roland> + struct minimal_symbol *indsym =
Roland> + indirect ? lookup_minimal_symbol_by_pc (pc + indirect) : 0;
Kai says that PC-relative expressions are relative to the end of the
instruction. So, 'pc + indirect' is incorrect here and also in the
read_memory call.
Tom