This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] GDB 7.2: new feature for "backtrace" that cuts path to file (remain filename)
- From: Eli Zaretskii <eliz at gnu dot org>
- To: iam ahal <hal9000ed2k at gmail dot com>
- Cc: tromey at redhat dot com, pedro at codesourcery dot com, dje at google dot com, gdb-patches at sourceware dot org, pmuldoon at redhat dot com, brobecker at adacore dot com, drow at false dot org, jan dot kratochvil at redhat dot com
- Date: Wed, 14 Mar 2012 19:40:12 +0200
- Subject: Re: [patch] GDB 7.2: new feature for "backtrace" that cuts path to file (remain filename)
- References: <BANLkTinD+9_Mkug8o2VhZ03L6XSriL_RKQ@mail.gmail.com> <83fwgzbrp9.fsf@gnu.org> <E1RXQvX-00045Q-Hk@fencepost.gnu.org> <201112061249.47758.pedro@codesourcery.com> <E1RXugC-0005av-VR@fencepost.gnu.org> <m3obvll9hr.fsf@fleche.redhat.com> <E1RYCLT-0000ap-OY@fencepost.gnu.org> <CAA18ub+S+5Tw4D8X=c4=J995Gc7goS_Bm4MfuYqV8BWndoTmrQ@mail.gmail.com>
- Reply-to: Eli Zaretskii <eliz at gnu dot org>
> Date: Sat, 10 Mar 2012 23:14:43 +0300
> From: iam ahal <hal9000ed2k@gmail.com>
> Cc: Tom Tromey <tromey@redhat.com>, pedro@codesourcery.com, dje@google.com, gdb-patches@sourceware.org, pmuldoon@redhat.com, brobecker@adacore.com, drow@false.org, jan.kratochvil@redhat.com
>
> I've tried carefully to fix documentation and a little piece of code.
> Also, I've added NEWS entry.
Thanks!
> +If backtraces isn't easy to read due to a long absolute filename path recorded and
Just "filename record", please. GNU Coding Standards frown on using
"path" for anything but PATH-style lists of directories.
> +you just want to see only a basename or a relative filename path, you can change this
^^^^
Same here: just "relative filename".
> +Display a filename recorded at the compilation time. This is the default.
^^^
Please remove "the", it's not needed here.
Also, I would say "exactly as recorded at compile time". I think this
is more clear.
> +@item set backtrace filename-display relative
> +Display a filename without the compilation directory part.
This is unclear. What does it mean, exactly? that the filename is
displayed relative to the compilation directory? Can you give me an
example? I will then suggest an alternative wording to make your
intent more clear.
> + add_setshow_enum_cmd ("filename-display", class_obscure,
> + filename_display_kind_names,
> + &filename_display_string, _("\
> +Set how to display filename in backtraces."), _("\
> +Show how to display filename in backtraces."), _("\
I think "filenames", in plural, is better here.
> * New options
>
> set backtrace filename-display as-recorded|basename|relative
> show backtrace filename-display
> Control a way in which a filename is displayed in backtraces.
^^^^^ ^^^^^^^^^^
"the way" and "filenames" (plural and without "a").
OK with those changes.