This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
Thank you Tom for the review. I have modified the test according to the example you have pointed. The new patch is attached. The changelogs are below. Code Changelog: 2012-03-14 Siva Chandra <sivachandra@google.com> Python scripting: Add new method Value.referenced_value to gdb.Value which can dereference pointer as well as reference values. * NEWS: Add entry under 'Python scripting' about the new method Value.referenced_value on gdb.Value objects. * python/py-value.c (valpy_referenced_value): New function defining a new method on gdb.Value objects which can dereference pointer and reference values. * testsuite/gdb.python/py-value.cc: Add test case for testing the methodology exposing C++ values to Python. * testsuite/gdb.python/py-value-cc.exp: Add tests testing the methodology exposing C++ values to Python. * testsuite/gdb.python/Makefile.in: Add py-value-cc to EXECUTABLES. Docs Changelog: 2012-03-14 Siva Chandra <sivachandra@google.com> * gdb.texinfo (Python API/Values From Inferior): Add description about the new method Value.referenced_value. Add description on how Value.dereference is different (and similar) to Value.referenced_value. OK to commit? If yes, I think someone should commit it for me. Thanks, Siva Chandra On Wed, Mar 14, 2012 at 9:18 PM, Tom Tromey <tromey@redhat.com> wrote: >>>>>> "Siva" == Siva Chandra <sivachandra@google.com> writes: > > Siva> I could not think of a better name than 'referenced_value' for this > Siva> method. > > Seems reasonable to me. > > Siva> About using prepare_for_testing, I notice that compilation fails with > Siva> this as gcc is being used to compile the test case and not g++. So, I > Siva> have not changed the exp file in this patch. > > You can do it by passing the "c++" option, e.g. from dispcxx.exp: > > if {[prepare_for_testing $testfile.exp $testfile $srcfile {debug c++}]} { > > The code bits are ok with this fixed. > > Tom
Attachment:
value_referenced_value_patch_v3.txt
Description: Text document
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |