This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Add dll trampoline code handling for windows 64bit


>>>>> "Roland" == Roland Schwingel <roland@onevision.com> writes:

Roland> - The jump destination is on 64bit windows of course 8 byte
Roland> long. I could not find a function that transforms this into a
Roland> CORE_ADDR like read_memory_unsigned_integer() it is doing in the
Roland> 32bit case.  So I did the transformation on my own. While this
Roland> is high performant it might not be the "official" gdb way. If
Roland> someone can give me a hint on how to the transformation the
Roland> "official" way I will adjust my patch - if wished.

Just use read_memory_unsigned_integer.
I think it is guaranteed that CORE_ADDR will not be larger than
ULONGEST.

I can't really comment on the rest of your patch.

I think it is big enough that it requires a copyright assignment.
If you don't have one, contact me off-list to get started.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]