This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 2/3] Implement new features needed for handling SystemTap probes


On Tuesday, March 13 2012, Mark Kettenis wrote:

>> From: Tom Tromey <tromey@redhat.com>
>> Date: Mon, 12 Mar 2012 08:21:00 -0600
>> 
>> >>>>> "Mark" == Mark Kettenis <mark.kettenis@xs4all.nl> writes:
>> 
>> Mark> As far as I can tell SystemTap is Linux-specific.  So I'd think its
>> Mark> support should go completely in Linux-specific -tdep.c files.
>> 
>> sdt.h is really more like an ELF feature.
>
> All evidence I have points towards the functions in i386-tdep.c being
> SystemTap-specific; that's probably why they have "stap" in their name
> ;).  They're only used from i386-linux-tdep.c, so it makes much more
> sense to put them there.  If somebody ever ports (or reimplements)
> SystemTap for another OS, we can always move them.  The same thing
> holds for arm-tdep.c vs. arm-linux-tdep.c of course.

I actually chose to put those functions on i386-tdep.c because they are
used by both {i386,amd64}-linux-tdep.c, and so I thought it would be a
good way to export them.  However, I can put them in i386-linux-tdep.c
and export via a new i386-linux-tdep.h, if that's OK.

-- 
Sergio


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]