This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Support Fortran common blocks with addresses >INT_MAX.
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Chris January <chris dot january at allinea dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 9 Mar 2012 11:39:04 -0800
- Subject: Re: [PATCH] Support Fortran common blocks with addresses >INT_MAX.
- References: <1331217037.2742.10.camel@gumtree>
Chris,
> The address of a Fortran common block may be >INT_MAX. fix_common_block
> should be using CORE_ADDR, not int.
>
> 2012-03-08 Chris January <chris.january@allinea.com>
>
> * stabsread.c (fix_common_block): Change type of valu argument
> to CORE_ADDR.
This change looks correct to me too. Did you run the testsuite to
validate the change, by any chance?
Do you have copyright assignment papers on file with the FSF? If not,
this change is sufficiently small that we can accept it, as well as
your other contribution ("Add another way of setting up [...]").
If you are planning on making other contributions in the future,
we should really get you started on the assignment process - contact
me privately if you'd like to do so.
--
Joel