This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] Darwin build fix for unused prototypes


Thanks for the suggestions. Please commit this, as I don't have access.

gdb/ChangeLog:

	* darwin-nat-info.c (_initialize_darwin_info_commands): Add
	prototype.
	(darwin_debug_port_info): Make static.
	* darwin-nat.c (_initialize_darwin_inferior): Add prototype.
	* machoread.c (_initialize_machoread): Add prototype.
	* i386-darwin-nat.c (i386_darwin_dr_set, i386_darwin_dr_get)
	(i386_darwin_set_control, i386_darwin_get_control)
	i386_darwin_dr_set_addr, i386_darwin_get_addr)
	i386_darwin_get_status, i386_darwin_get_control):
	Hide these with HW_WATCHPOINT_NOT_YET_ENABLED.

Cheers,
Josh

On 9 March 2012 08:40, Joel Brobecker <brobecker@adacore.com> wrote:
> Hi Josh,
>
>> 2012-03-08 ?Josh Matthews ?<josh@joshmatthews.net>
>>
>> ? ? ? ? * darwin-nat-info.c: Add missing prototype for
>> _initialize_darwin_info_commands. Make darwin_debug_port_info static.
>> ? ? ? ? * darwin-nat.c: Add missing prototype for _initialize_darwin_infereior.
>> ? ? ? ? * i386-darwin-nat.c: Remove unused functions
>> i386_darwin_dr_set, i386_darwin_dr_get, i386_darwin_set_control,
>> i386_darwin_get_control, i386_darwin_dr_set_addr,
>> i386_darwin_get_addr, i386_darwin_get_status, i386_darwin_get_control.
>> ? ? ? ? * machoread.c: Add missing prototype for _initialize_machoread.
>
> Before you commit, can you make sure you re-format this ChangeLog
> entry so that all the text is aligned on a tab? Also, can you use
> two spaces after each period. And finally, I noticed at least one
> typo:
>
> ? ? ? ?_initialize_darwin_infereior
>
> I suggest:
>
> ? ? ? ?* darwin-nat-info.c (_initialize_darwin_info_commands): Add
> ? ? ? ?prototype.
> ? ? ? ?(darwin_debug_port_info): Make static.
> ? ? ? ?* darwin-nat.c (_initialize_darwin_inferior): Add prototype.
> ? ? ? ?* machoread.c (_initialize_machoread): Add prototype.
> ? ? ? ?* i386-darwin-nat.c (i386_darwin_dr_set, i386_darwin_dr_get)
> ? ? ? ?(i386_darwin_set_control, i386_darwin_get_control)
> ? ? ? ?i386_darwin_dr_set_addr, i386_darwin_get_addr)
> ? ? ? ?i386_darwin_get_status, i386_darwin_get_control):
> ? ? ? ?Comment these functions out.
>
> --
> Joel

Attachment: darwin_prototypes.diff
Description: Binary data


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]