This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] gdb_get_line_number on unknown tags


> Well, we three agree, so here it is. It exposed buglets in three
> other tests (which appear to be copies of one common file).
[...]
> testsuite/ChangeLog
> 2012-03-08  Keith Seitz  <keiths@redhat.com>
> 
> 	* lib/gdb.exp (gdb_get_line_number): Throw an
> 	error instead of returning -1.
> 	* gdb.base/break.exp: Remove unused variable
> 	bp_location5.
> 	* gdb.base/hbreak2.exp: Likewise.
> 	* gdb.base/sepdebug.exp: Likewise.

Nice! This looks good to me. But perhaps Tom, who know TCL way better
than I do (and most likely you do too), might want to comment too?

The changes in gdb.base can go in as obvious on their own in any case.

-- 
Joel


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]