This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] remote: Fix a crash on longjmp breakpoint removal


On 03/07/2012 08:08 PM, Maciej W. Rozycki wrote:

>  So I have finally got back to it and noticed that this:
> 
> http://sourceware.org/ml/gdb-patches/2012-01/msg00701.html
> 
> has already fixed the problem -- shall we close gdb/13333 then?  


If it's fixed, yes.

> I think we should still add Keith's test case to cover any possible future 
> breakage in this area -- the fix didn't include any.  


py-finish-breakpoint.exp was failing against gdbserver without the fix.
I don't mind adding a new test.  Keith's was using gdb_expect, which we
very much like to avoid.  Can it be made to use gdb_test or
gdb_test_multiple?

> I suggest that we retrofit the ChangeLog entry with a reference too.


Please go ahead.

-- 
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]