This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Make AX engine fail gracefully due to unknown types
- From: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- To: Luis Gustavo <luis_gustavo at mentor dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 7 Mar 2012 21:22:03 +0100
- Subject: Re: [PATCH] Make AX engine fail gracefully due to unknown types
- References: <4F57A77E.307@mentor.com>
On Wed, 07 Mar 2012 19:22:54 +0100, Luis Gustavo wrote:
> +++ HEAD-git/gdb/ax-gdb.c 2012-03-07 14:16:23.846145476 -0300
> @@ -557,8 +557,8 @@ gen_fetch (struct agent_expr *ax, struct
> pointer (other code's fault), or we're not implementing
> something we should be (this code's fault). In any case,
> it's a bug the user shouldn't see. */
> - internal_error (__FILE__, __LINE__,
> - _("gen_fetch: bad type code"));
> + error (_("gen_fetch: Unsupported type code `%s'."),
> + TYPE_NAME (type));
I find it OK but here the comment should be updated.
Thanks,
Jan