This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] s390-nat.c: Fix missing prototypes


Joel Brobecker <brobecker@adacore.com> writes:

>> Tested on s390x-ibm-linux with no regressions, fixes a
>> -Wmissing-prototypes build failure.
>> 
>> gdb/
>> 2012-03-05  Andreas Arnez  <arnez@linux.vnet.ibm.com>
>> 
>> 	* s390-nat.c: Include "gregset.h".
>
> Thanks! Attached is what I committed for you. I dropped the comment,
> since I felt it was completely redundant.

Thanks!  Dropping the comment is OK.  However, you also relocated the
include statement.  This doesn't work, because "gregset.h" uses a
typedef from the system header file <sys/ucontext.h>.  The order of
inclusion matters, and any other than my original patch may not work
either.

-- Andreas


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]