This is the mail archive of the
mailing list for the GDB project.
Re: [patch 1/2] libunwind/ia64: Rename libunwind-frame.[ch]
- From: Pedro Alves <palves at redhat dot com>
- To: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 06 Mar 2012 07:54:35 +0000
- Subject: Re: [patch 1/2] libunwind/ia64: Rename libunwind-frame.[ch]
- References: <20120304215728.GA2763@host2.jankratochvil.net>
On 03/04/2012 09:57 PM, Jan Kratochvil wrote:
> this is just a rename, it breaks the build, but it makes the changes
> reviewable in [patch 2/2]. It would be checked-in as a single commit.
BTW, there's a different way to split this so that you don't mix
the rename with other changes to the same files, and so that
git log sees through pure file renames without trouble.
That is, you rename the header in one patch, and rename the
c file in the other patch. For example:
In patch #1 rename libunwind-frame.h -> ia64-tdep-libunwind-frame.h
but otherwise don't touch ia64-tdep-libunwind-frame.h. Also do all
other adjustments to the other files so that the build doesn't break
(except for the build bits that need adjustment to compile
In patch #2 rename libunwind-frame.c -> ia64-tdep-libunwind-frame.c
but otherwise don't touch ia64-tdep-libunwind-frame.c. Do the
build bits adjustment to build ia64-tdep-libunwind-frame.o instead
in this patch.
Or the other way around, (there's more than one
way to split this). The point is not to touch the same file
you're renaming in the same commit you're doing the rename in.