This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[committed]: [patch] Run gdb.trace/ftrace.exp on `x86_64 -m64' and setup kfail


On 03/06/2012 12:25 AM, Pedro Alves wrote:
> On 03/05/2012 03:34 PM, Yao Qi wrote:
>> The original condition in ftrace.exp is `is_x86_like_target',
>> which return 1 if target is an x86 or x86_64 with -m32.  I
>> can't see any reason why this case can't run on `x86_64 -m64'.
>> This patch is to relax this condition a little.
>>
>> After changing this condition, I got two FAILs on x86_64-linux.
>> Open PR 13808 to track them, and set up KFAIL in test case.
>>
>>   http://sourceware.org/bugzilla/show_bug.cgi?id=13808
>>
>> OK to apply?
> 
> OK with ...
> 
>> -    if { [is_x86_like_target] } {
>> +    if { [istarget "x86_64-*-linux*"] || [istarget "i\[34567\]86-*-linux*"] } {
> 
> 
> ...
> 
> +    if { [istarget "x86_64-*-*"] || [istarget "i\[34567\]86-*-*"] } {
> 

This is what I committed.

http://sourceware.org/ml/gdb-cvs/2012-03/msg00108.html

-- 
Yao (éå) 

2012-03-06  Yao Qi  <yao@codesourcery.com>

	* gdb.trace/ftrace.exp (test_fast_tracepoints): Run test on target
	x86_64-*-* and i?86-*-*.
	Set up KFAIL for gdb/13808.

Index: testsuite/gdb.trace/ftrace.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.trace/ftrace.exp,v
retrieving revision 1.3
diff -u -r1.3 ftrace.exp
--- testsuite/gdb.trace/ftrace.exp	4 Jan 2012 08:27:55 -0000	1.3
+++ testsuite/gdb.trace/ftrace.exp	6 Mar 2012 01:27:49 -0000
@@ -86,7 +86,7 @@
 
     gdb_test "print gdb_agent_gdb_trampoline_buffer_error" ".*" ""
 
-    if { [is_x86_like_target] } {
+    if { [istarget "x86_64-*-*"] || [istarget "i\[34567\]86-*-*"] } {
 
 	gdb_test "ftrace set_point" "Fast tracepoint .*" \
 	    "fast tracepoint at a long insn"
@@ -134,11 +134,13 @@
 	gdb_test "tfind pc *set_point" "Found trace frame .*" \
 	    "tfind set_point frame, first time"
 
+	setup_kfail_for_target "gdb/13808" "x86_64-*-linux*"
 	gdb_test "print globvar" " = 1"
 
 	gdb_test "tfind pc *set_point" "Found trace frame .*" \
 	    "tfind set_point frame, second time"
 
+	setup_kfail_for_target "gdb/13808" "x86_64-*-linux*"
 	gdb_test "print anarg" " = 200"
 
 	gdb_test "tfind start" "Found trace frame .*" \


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]