This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[commit] Remove dead libunwind-ia64 code


Hi,

removed dead code:

libunwind_frame_unwind is 'static const' which is never reported by GCC
-Wunused-variable; unrelated but the reasons are in:
	http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28901
(clang also does not report it)

libunwind_frame_base_address was also unused, this may be a bug, filed it for
the record as:
	STABS not supported on ia64 with libunwind
	http://sourceware.org/bugzilla/show_bug.cgi?id=13801


Regards,
Jan


http://sourceware.org/ml/gdb-cvs/2012-03/msg00083.html

--- src/gdb/ChangeLog	2012/03/04 03:31:09	1.13949
+++ src/gdb/ChangeLog	2012/03/04 19:22:46	1.13950
@@ -1,3 +1,10 @@
+2012-03-04  Jan Kratochvil  <jan.kratochvil@redhat.com>
+
+	Removed unused code.
+	* libunwind-frame.c (libunwind_frame_unwind)
+	(libunwind_frame_base_address): Remove.
+	* libunwind-frame.h (libunwind_frame_base_address): Remove declaration.
+
 2012-03-04  Yao Qi  <yao@codesourcery.com>
 
 	* common/agent.c (gdb_connect_sync_socket): Add _ markup and
--- src/gdb/libunwind-frame.c	2012/02/21 19:39:32	1.35
+++ src/gdb/libunwind-frame.c	2012/03/04 19:22:47	1.36
@@ -241,17 +241,6 @@
   return unw_find_dyn_list_p (as, di, arg);
 }
 
-static const struct frame_unwind libunwind_frame_unwind =
-{
-  NORMAL_FRAME,
-  default_frame_unwind_stop_reason,
-  libunwind_frame_this_id,
-  libunwind_frame_prev_register,
-  NULL,
-  libunwind_frame_sniffer,
-  libunwind_frame_dealloc_cache,
-};
-
 /* Verify if there is sufficient libunwind information for the frame to use
    libunwind frame unwinding.  */
 int
@@ -384,17 +373,6 @@
   return val;
 } 
 
-CORE_ADDR
-libunwind_frame_base_address (struct frame_info *this_frame, void **this_cache)
-{
-  struct libunwind_frame_cache *cache =
-    libunwind_frame_cache (this_frame, this_cache);
-
-  if (cache == NULL)
-    return (CORE_ADDR)NULL;
-  return cache->base;
-}
-
 /* The following is a glue routine to call the libunwind unwind table
    search function to get unwind information for a specified ip address.  */ 
 int
--- src/gdb/libunwind-frame.h	2012/02/21 19:39:32	1.18
+++ src/gdb/libunwind-frame.h	2012/03/04 19:22:47	1.19
@@ -60,8 +60,6 @@
 struct value *libunwind_frame_prev_register (struct frame_info *this_frame,
                                              void **this_cache, int regnum);
 void libunwind_frame_dealloc_cache (struct frame_info *self, void *cache);
-CORE_ADDR libunwind_frame_base_address (struct frame_info *this_frame,
-                                        void **this_cache);
 
 int libunwind_is_initialized (void);
 


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]