This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [commit/Ada] print packed arrays indexed by enumerated type
- From: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Sat, 3 Mar 2012 15:02:13 +0100
- Subject: Re: [commit/Ada] print packed arrays indexed by enumerated type
- References: <1330544108-25710-1-git-send-email-brobecker@adacore.com>
On Wed, 29 Feb 2012 20:35:08 +0100, Joel Brobecker wrote:
> gdb/ChangeLog:
>
> * ada-lang.c (constrained_packed_array_type): If there is a
> parallel XA type, use it to determine the array index type.
>
> gdb/testsuite/ChangeLog:
>
> * gdb.ada/arrayidx.exp: Adjust expected output for p_one_two_three.
> * gdb.ada/enum_idx_packed: New testcase.
Do you agree with these XFAILs? I did not bisect which GCC change it was.
Also gcc-4.7.0-0.16.fc17.x86_64 still FAILs despite it is 4.7; but that may
change with later updates, not sure.
Regards,
Jan
gdb/testsuite/
2012-03-03 Jan Kratochvil <jan.kratochvil@redhat.com>
* gdb.ada/arrayidx.exp: Call get_compiler_info. New variable old_gcc.
(print one_two_three, indexes off, print few_reps, indexes off)
(print many_reps, indexes off, print empty, indexes off)
(print one_two_three, print few_reps, print many_reps, print empty):
Call setup_xfail if $gcc_old.
--- a/gdb/testsuite/gdb.ada/arrayidx.exp
+++ b/gdb/testsuite/gdb.ada/arrayidx.exp
@@ -27,6 +27,12 @@ if {[gdb_compile_ada "${srcfile}" "${binfile}" executable {debug}] != ""} {
return -1
}
+if [get_compiler_info ${binfile}] {
+ return -1;
+}
+set old_gcc [expr [test_compiler_info {gcc-[0-3]-*}] \
+ || [test_compiler_info {gcc-4-[0-6]-*}]]
+
clean_restart ${testfile}
set bp_location [gdb_get_line_number "START" ${testdir}/p.adb]
@@ -36,6 +42,9 @@ runto "p.adb:$bp_location"
gdb_test_no_output "set print array-indexes off"
+if $old_gcc {
+ setup_xfail "*-*-*"
+}
gdb_test "print one_two_three" \
"= \\(1, 2, 3\\)" \
"print one_two_three, indexes off"
@@ -56,14 +65,23 @@ gdb_test "print p_one_two_three" \
"= \\(false, true, true\\)" \
"print p_one_two_three, indexes off"
+if $old_gcc {
+ setup_xfail "*-*-*"
+}
gdb_test "print few_reps" \
"= \\(1, 2, 3, 3, 3, 3, 3, 4, 5\\)" \
"print few_reps, indexes off"
+if $old_gcc {
+ setup_xfail "*-*-*"
+}
gdb_test "print many_reps" \
"= \\(1, 2, 3 <repeats 12 times>, 4, 5\\)" \
"print many_reps, indexes off"
+if $old_gcc {
+ setup_xfail "*-*-*"
+}
gdb_test "print empty" \
"= \\(\\)" \
"print empty, indexes off"
@@ -72,6 +90,9 @@ gdb_test "print empty" \
gdb_test_no_output "set print array-indexes on"
+if $old_gcc {
+ setup_xfail "*-*-*"
+}
gdb_test "print one_two_three" \
"= \\(1 => 1, 2 => 2, 3 => 3\\)" \
"print one_two_three"
@@ -92,14 +113,23 @@ gdb_test "print p_one_two_three" \
"= \\(one => false, two => true, three => true\\)" \
"print p_one_two_three"
+if $old_gcc {
+ setup_xfail "*-*-*"
+}
gdb_test "print few_reps" \
"= \\(1 => 1, 2 => 2, 3 => 3, 4 => 3, 5 => 3, 6 => 3, 7 => 3, 8 => 4, 9 => 5\\)" \
"print few_reps"
+if $old_gcc {
+ setup_xfail "*-*-*"
+}
gdb_test "print many_reps" \
"= \\(1 => 1, 2 => 2, 3 => 3 <repeats 12 times>, 15 => 4, 16 => 5\\)" \
"print many_reps"
+if $old_gcc {
+ setup_xfail "*-*-*"
+}
gdb_test "print empty" \
"= \\(\\)" \
"print empty"