This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
C version of jit-reader.h:plugin_is_GPL_compatible broken
- From: Pedro Alves <palves at redhat dot com>
- To: gdb-patches at sourceware dot org
- Date: Thu, 01 Mar 2012 21:25:33 +0000
- Subject: C version of jit-reader.h:plugin_is_GPL_compatible broken
- References: <20120229161628.23918.51354.stgit@hit-nxdomain.opendns.com> <20120229161951.23918.68388.stgit@hit-nxdomain.opendns.com> <4F4E5C55.1040909@redhat.com>
On 02/29/2012 05:11 PM, Pedro Alves wrote:
> On 02/29/2012 04:19 PM, Pedro Alves wrote:
>> #define GDB_DECLARE_GPL_COMPATIBLE_READER
>> + extern int plugin_is_GPL_compatible (void); \
>> extern int plugin_is_GPL_compatible (void) \
>
> Hmm, I just noticed this is broken, even before my patch.
> There's a `\' missing at the end of GDB_DECLARE_GPL_COMPATIBLE_READER,
> like in:
>
> #define GDB_DECLARE_GPL_COMPATIBLE_READER \
> extern int plugin_is_GPL_compatible (void) \
>
> This is the !__cplusplus variant. The C++ variant is okay.
>
I'm checking this in.
2012-03-01 Pedro Alves <palves@redhat.com>
* jit-reader.in [!__cplusplus]
(GDB_DECLARE_GPL_COMPATIBLE_READER): Add missing backslash.
---
diff --git a/gdb/jit-reader.in b/gdb/jit-reader.in
index 42c28b5..3ad521a 100644
--- a/gdb/jit-reader.in
+++ b/gdb/jit-reader.in
@@ -45,7 +45,7 @@ extern "C" {
#else
-#define GDB_DECLARE_GPL_COMPATIBLE_READER
+#define GDB_DECLARE_GPL_COMPATIBLE_READER \
extern int plugin_is_GPL_compatible (void); \
extern int plugin_is_GPL_compatible (void) \
{ \