This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA 2/2] Varobj support for Ada.
- From: Tom Tromey <tromey at redhat dot com>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Thu, 01 Mar 2012 14:11:13 -0700
- Subject: Re: [RFA 2/2] Varobj support for Ada.
- References: <1330555268-32692-1-git-send-email-brobecker@adacore.com> <1330555268-32692-3-git-send-email-brobecker@adacore.com>
>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:
Joel> There is one bit, however, this is in varobj.c which could use some
Joel> discussion. I marked it with a FIXME, and I took the simple approach
Joel> for now. I think it's OK as is, but I also think that having an extra
Joel> hook in the varobj vector would be a nice improvement. That's not
Joel> the only one, as ISTM that the code just above it screems for
Joel> language-specific hook... I'd be happy to do that, I just didn't want
Joel> to do it on my own. And I was hoping that it'd be OK to do that as
Joel> a followup patch.
I agree that a new method would be preferable.
Joel> PS: I think that the language-dependent (in other words the language-
Joel> specific) hook for varobj support, should follow the same example.
Joel> In fact, I'm wonder whether we could simply have languages registering
Joel> support in varobj, and get rid of the big static table that we have.
Joel> Sometime similar to the language vector...
I agree. This varobj-specific language vector, and enum
varobj_languages, has always bugged me a bit.
Tom