This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[commit] remove unused fields in struct dwarf2_cu
- From: dje at google dot com (Doug Evans)
- To: gdb-patches at sourceware dot org
- Date: Thu, 1 Mar 2012 11:56:29 -0800 (PST)
- Subject: [commit] remove unused fields in struct dwarf2_cu
- Authentication-results: mr.google.com; spf=pass (google.com: domain of dje@google.com designates 10.14.186.9 as permitted sender) smtp.mail=dje@google.com; dkim=pass header.i=dje@google.com
Hi.
These fields aren't used anywhere so I deleted them.
2012-03-01 Doug Evans <dje@google.com>
* dwarf2read.c (dwarf2_cu): Remove unused members has_form_ref_addr,
has_namespace_info.
(dwarf2_read_abbrevs): Remove corresponding initialization.
Index: dwarf2read.c
===================================================================
RCS file: /cvs/src/src/gdb/dwarf2read.c,v
retrieving revision 1.615
diff -u -p -r1.615 dwarf2read.c
--- dwarf2read.c 22 Feb 2012 14:55:25 -0000 1.615
+++ dwarf2read.c 1 Mar 2012 19:51:43 -0000
@@ -378,16 +378,6 @@ struct dwarf2_cu
/* Mark used when releasing cached dies. */
unsigned int mark : 1;
- /* This flag will be set if this compilation unit might include
- inter-compilation-unit references. */
- unsigned int has_form_ref_addr : 1;
-
- /* This flag will be set if this compilation unit includes any
- DW_TAG_namespace DIEs. If we know that there are explicit
- DIEs for namespaces, we don't need to try to infer them
- from mangled names. */
- unsigned int has_namespace_info : 1;
-
/* This CU references .debug_loc. See the symtab->locations_valid field.
This test is imperfect as there may exist optimized debug code not using
any location list and still facing inlining issues if handled as
@@ -9343,9 +9333,6 @@ dwarf2_read_abbrevs (struct dwarf2_cu *c
cur_abbrev->has_children = read_1_byte (abfd, abbrev_ptr);
abbrev_ptr += 1;
- if (cur_abbrev->tag == DW_TAG_namespace)
- cu->has_namespace_info = 1;
-
/* now read in declarations */
abbrev_name = read_unsigned_leb128 (abfd, abbrev_ptr, &bytes_read);
abbrev_ptr += bytes_read;
@@ -9361,16 +9348,6 @@ dwarf2_read_abbrevs (struct dwarf2_cu *c
* sizeof (struct attr_abbrev)));
}
- /* Record whether this compilation unit might have
- inter-compilation-unit references. If we don't know what form
- this attribute will have, then it might potentially be a
- DW_FORM_ref_addr, so we conservatively expect inter-CU
- references. */
-
- if (abbrev_form == DW_FORM_ref_addr
- || abbrev_form == DW_FORM_indirect)
- cu->has_form_ref_addr = 1;
-
cur_attrs[cur_abbrev->num_attrs].name = abbrev_name;
cur_attrs[cur_abbrev->num_attrs++].form = abbrev_form;
abbrev_name = read_unsigned_leb128 (abfd, abbrev_ptr, &bytes_read);
@@ -10116,9 +10093,7 @@ fixup_partial_die (struct partial_die_in
/* If there is no parent die to provide a namespace, and there are
children, see if we can determine the namespace from their linkage
- name.
- NOTE: We need to do this even if cu->has_namespace_info != 0.
- gcc-4.5 -gdwarf-4 can drop the enclosing namespace. */
+ name. */
if (cu->language == language_cplus
&& !VEC_empty (dwarf2_section_info_def, dwarf2_per_objfile->types)
&& part_die->die_parent == NULL