This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[2/5] FYI: change common_val_print to return void
- From: Tom Tromey <tromey at redhat dot com>
- To: gdb-patches at sourceware dot org
- Date: Thu, 01 Mar 2012 12:10:11 -0700
- Subject: [2/5] FYI: change common_val_print to return void
I'm checking this in.
Nothing uses common_val_print's return value.
This changes it to return void.
Tom
b/gdb/ChangeLog:
2012-03-01 Tom Tromey <tromey@redhat.com>
* value.h (common_val_print): Return void.
* valprint.c (common_val_print): Return void.
>From bfdd646cc9c0c73d49ef81177c3108e13eb92b16 Mon Sep 17 00:00:00 2001
From: Tom Tromey <tromey@redhat.com>
Date: Fri, 3 Feb 2012 08:51:31 -0700
Subject: [PATCH 2/5] change common_val_print to return void
---
gdb/ChangeLog | 5 +++++
gdb/valprint.c | 15 ++++++---------
gdb/value.h | 8 ++++----
3 files changed, 15 insertions(+), 13 deletions(-)
diff --git a/gdb/valprint.c b/gdb/valprint.c
index 9ff0f27..a543552 100644
--- a/gdb/valprint.c
+++ b/gdb/valprint.c
@@ -432,19 +432,16 @@ value_check_printable (struct value *val, struct ui_file *stream,
/* Print using the given LANGUAGE the value VAL onto stream STREAM according
to OPTIONS.
- If the data are a string pointer, returns the number of string characters
- printed.
-
This is a preferable interface to val_print, above, because it uses
GDB's value mechanism. */
-int
+void
common_val_print (struct value *val, struct ui_file *stream, int recurse,
const struct value_print_options *options,
const struct language_defn *language)
{
if (!value_check_printable (val, stream, options))
- return 0;
+ return;
if (language->la_language == language_ada)
/* The value might have a dynamic type, which would cause trouble
@@ -453,10 +450,10 @@ common_val_print (struct value *val, struct ui_file *stream, int recurse,
get a fixed representation of our value. */
val = ada_to_fixed_value (val);
- return val_print (value_type (val), value_contents_for_printing (val),
- value_embedded_offset (val), value_address (val),
- stream, recurse,
- val, options, language);
+ val_print (value_type (val), value_contents_for_printing (val),
+ value_embedded_offset (val), value_address (val),
+ stream, recurse,
+ val, options, language);
}
/* Print on stream STREAM the value VAL according to OPTIONS. The value
diff --git a/gdb/value.h b/gdb/value.h
index 9706e70..bb6f1f6 100644
--- a/gdb/value.h
+++ b/gdb/value.h
@@ -824,10 +824,10 @@ extern int val_print (struct type *type, const gdb_byte *valaddr,
const struct value_print_options *options,
const struct language_defn *language);
-extern int common_val_print (struct value *val,
- struct ui_file *stream, int recurse,
- const struct value_print_options *options,
- const struct language_defn *language);
+extern void common_val_print (struct value *val,
+ struct ui_file *stream, int recurse,
+ const struct value_print_options *options,
+ const struct language_defn *language);
extern int val_print_string (struct type *elttype, const char *encoding,
CORE_ADDR addr, int len,
--
1.7.7.6