This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
FYI: remove extraneous block from dw2_map_symtabs_matching_filename
- From: Tom Tromey <tromey at redhat dot com>
- To: gdb-patches at sourceware dot org
- Date: Mon, 20 Feb 2012 12:24:12 -0700
- Subject: FYI: remove extraneous block from dw2_map_symtabs_matching_filename
I'm checking this in.
While debugging an extremely slow test case, I tripped across an
apparently-extraneous block in dw2_map_symtabs_matching_filename that
can cause all CUs to be expanded.
Removing this block fixes at least part of the slowdown.
This might have been caused by a bad merge at some point.
It is hard to know for sure. It originated with my relative file
name patch for linespec.
Tom
2012-02-20 Tom Tromey <tromey@redhat.com>
* dwarf2read.c (dw2_map_symtabs_matching_filename): Remove
extraneous block.
Index: dwarf2read.c
===================================================================
RCS file: /cvs/src/src/gdb/dwarf2read.c,v
retrieving revision 1.612
diff -u -r1.612 dwarf2read.c
--- dwarf2read.c 7 Feb 2012 04:48:19 -0000 1.612
+++ dwarf2read.c 20 Feb 2012 19:21:26 -0000
@@ -2437,13 +2437,6 @@
return 1;
}
- {
- if (dw2_map_expand_apply (objfile, per_cu,
- name, full_path, real_path,
- callback, data))
- return 1;
- }
-
/* Before we invoke realpath, which can get expensive when many
files are involved, do a quick comparison of the basenames. */
if (! basenames_may_differ