This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [4/4] RFC: implement catch load and catch unload


> From: Tom Tromey <tromey@redhat.com>
> Date: Thu, 19 Jan 2012 13:35:57 -0700
> 
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -28,6 +28,11 @@
>    now set a breakpoint in build/gcc/expr.c, but not
>    build/libcpp/expr.c.
>  
> +* New commands
> +
> +  ** "catch load" and "catch unload" can be used to stop when a shared
> +     library is loaded or unloaded, respectively.
> +

This part is okay.

> --- a/gdb/doc/gdb.texinfo
> +++ b/gdb/doc/gdb.texinfo

This part is also okay, but I have one minor comment:

> +@item load @r{[}regexp@r{]}
> +@itemx unload @r{[}regexp@r{]}
> +The loading or unloading of a shared library.  If @var{regexp} is
> +given, then the catchpoint will stop only if it matches one of the
> +affected libraries.                          ^^

That "it" in the last sentence is ambiguous: can be interpreted to
reference the catchpoint instead of the regexp.  How about replacing
it with "the regular expression"?

Thanks.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]